feat(*) update project to build kumactl at windows

Signed-off-by: Bart Smykla <bartek@smykla.com>

app/kumactl/cmd/additional_subcommands.go

@@ -0,0 +1,14 @@
+// +build !windows
+
+package cmd
+
+import (
+	"github.com/spf13/cobra"
+
+	"github.com/kumahq/kuma/app/kumactl/cmd/uninstall"
+	kumactl_cmd "github.com/kumahq/kuma/app/kumactl/pkg/cmd"
+)
+
+var additionalSubcommands = []func(*kumactl_cmd.RootContext) *cobra.Command{
+	uninstall.NewUninstallCmd,
+}

app/kumactl/cmd/additional_subcommands_windows.go

@@ -0,0 +1,18 @@
+package cmd
+
+import (
+	"github.com/kumahq/kuma/app/kumactl/cmd/apply"
+	"github.com/kumahq/kuma/app/kumactl/cmd/completion"
+	"github.com/kumahq/kuma/app/kumactl/cmd/config"
+	"github.com/kumahq/kuma/app/kumactl/cmd/delete"
+	"github.com/kumahq/kuma/app/kumactl/cmd/generate"
+	"github.com/kumahq/kuma/app/kumactl/cmd/get"
+	"github.com/kumahq/kuma/app/kumactl/cmd/inspect"
+	"github.com/kumahq/kuma/app/kumactl/cmd/install"
+	"github.com/kumahq/kuma/pkg/cmd/version"
+	"github.com/spf13/cobra"
+
+	kumactl_cmd "github.com/kumahq/kuma/app/kumactl/pkg/cmd"
+)
+
+var additionalSubcommands []func(*kumactl_cmd.RootContext) *cobra.Command

app/kumactl/cmd/install/additional_subcommands.go

@@ -0,0 +1,11 @@
+// +build !windows
+
+package install
+
+import (
+	"github.com/spf13/cobra"
+)
+
+var additionalSubcommands = []func() *cobra.Command{
+	newInstallTransparentProxy,
+}

app/kumactl/cmd/install/additional_subcommands_windows.go

@@ -0,0 +1,7 @@
+package install
+
+import (
+	"github.com/spf13/cobra"
+)
+
+var additionalSubcommands []func() *cobra.Command

app/kumactl/cmd/install/install.go

@@ -12,15 +12,20 @@ func NewInstallCmd(pctx *kumactl_cmd.RootContext) *cobra.Command {
 		Short: "Install various Kuma components.",
 		Long:  `Install various Kuma components.`,
 	}
+
 	// sub-commands
 	cmd.AddCommand(newInstallControlPlaneCmd(&pctx.InstallCpContext))
 	cmd.AddCommand(newInstallCrdsCmd(&pctx.InstallCRDContext))
 	cmd.AddCommand(newInstallMetrics(pctx))
 	cmd.AddCommand(newInstallTracing(pctx))
 	cmd.AddCommand(newInstallDNS())
 	cmd.AddCommand(newInstallLogging(pctx))
-	cmd.AddCommand(newInstallTransparentProxy())
 	cmd.AddCommand(newInstallDemoCmd(&pctx.InstallDemoContext))
 	cmd.AddCommand(newInstallGatewayCmd(pctx))
+
+	for _, subcommand := range additionalSubcommands {
+		cmd.AddCommand(subcommand())
+	}
+
 	return cmd
 }

app/kumactl/cmd/install/install_transparent_proxy.go

@@ -1,3 +1,5 @@
+// +build !windows
+
 package install
 
 import (

app/kumactl/cmd/root.go

@@ -14,7 +14,6 @@ import (
 	"github.com/kumahq/kuma/app/kumactl/cmd/get"
 	"github.com/kumahq/kuma/app/kumactl/cmd/inspect"
 	"github.com/kumahq/kuma/app/kumactl/cmd/install"
-	"github.com/kumahq/kuma/app/kumactl/cmd/uninstall"
 	kumactl_cmd "github.com/kumahq/kuma/app/kumactl/pkg/cmd"
 	kumactl_config "github.com/kumahq/kuma/app/kumactl/pkg/config"
 	kumactl_errors "github.com/kumahq/kuma/app/kumactl/pkg/errors"
@@ -106,8 +105,12 @@ func NewRootCmd(root *kumactl_cmd.RootContext) *cobra.Command {
 	cmd.AddCommand(get.NewGetCmd(root))
 	cmd.AddCommand(inspect.NewInspectCmd(root))
 	cmd.AddCommand(install.NewInstallCmd(root))
-	cmd.AddCommand(uninstall.NewUninstallCmd(root))
 	cmd.AddCommand(version.NewVersionCmd())
+
+	for _, subcommand := range additionalSubcommands {
+		cmd.AddCommand(subcommand(root))
+	}
+
 	kumactl_cmd.WrapRunnables(cmd, kumactl_errors.FormatErrorWrapper)
 	return cmd
 }

app/kumactl/cmd/uninstall/subcommands.go

@@ -0,0 +1,9 @@
+// +build !windows
+
+package uninstall
+
+import "github.com/spf13/cobra"
+
+var subcommands = []func() *cobra.Command{
+	newUninstallTransparentProxy,
+}

app/kumactl/cmd/uninstall/subcommands_windows.go

@@ -0,0 +1,5 @@
+package uninstall
+
+import "github.com/spf13/cobra"
+
+var subcommands []func() *cobra.Command

app/kumactl/cmd/uninstall/uninstall.go

@@ -12,7 +12,11 @@ func NewUninstallCmd(pctx *kumactl_cmd.RootContext) *cobra.Command {
 		Short: "Uninstall various Kuma components.",
 		Long:  `Uninstall various Kuma components.`,
 	}
+
 	// sub-commands
-	cmd.AddCommand(newUninstallTransparentProxy())
+	for _, subcommand := range subcommands {
+		cmd.AddCommand(subcommand())
+	}
+
 	return cmd
 }

app/kumactl/cmd/uninstall/uninstall_transparent_proxy.go

@@ -11,13 +11,13 @@ import (
 	"github.com/kumahq/kuma/pkg/transparentproxy"
 )
 
-type transparenProxyArgs struct {
+type transparentProxyArgs struct {
 	DryRun  bool
 	Verbose bool
 }
 
 func newUninstallTransparentProxy() *cobra.Command {
-	args := transparenProxyArgs{
+	args := transparentProxyArgs{
 		DryRun:  false,
 		Verbose: false,
 	}

app/kumactl/cmd/uninstall/uninstall_windows.go

@@ -0,0 +1,19 @@
+// +build !windows
+
+package uninstall
+
+import (
+	"github.com/spf13/cobra"
+
+	kumactl_cmd "github.com/kumahq/kuma/app/kumactl/pkg/cmd"
+)
+
+func NewUninstallCmd(pctx *kumactl_cmd.RootContext) *cobra.Command {
+	cmd := &cobra.Command{
+		Use:   "uninstall",
+		Short: "Uninstall various Kuma components.",
+		Long:  `Uninstall various Kuma components.`,
+	}
+
+	return cmd
+}

pkg/config/xds/bootstrap/config.go

@@ -84,13 +84,13 @@ func (b *BootstrapParamsConfig) Validate() error {
 	return nil
 }
 
-func DefaultBootstrapParamsConfig() *BootstrapParamsConfig {
+func buildDefaultBootstrapParamsConfig(adminAccessLogPath string) *BootstrapParamsConfig {
 	return &BootstrapParamsConfig{
 		AdminAddress:       "127.0.0.1", // by default, Envoy Admin interface should listen on loopback address
 		AdminPort:          0,           // by default, turn off Admin interface of Envoy
-		AdminAccessLogPath: "/dev/null",
-		XdsHost:            "", // by default it is the same host as the one used by kuma-dp to connect to the control plane
-		XdsPort:            0,  // by default it is autoconfigured from KUMA_XDS_SERVER_GRPC_PORT
+		AdminAccessLogPath: adminAccessLogPath,
+		XdsHost:            "", // by default, it is the same host as the one used by kuma-dp to connect to the control plane
+		XdsPort:            0,  // by default, it is autoconfigured from KUMA_XDS_SERVER_GRPC_PORT
 		XdsConnectTimeout:  1 * time.Second,
 	}
 }

pkg/config/xds/bootstrap/default_params.go

@@ -0,0 +1,7 @@
+// +build !windows
+
+package bootstrap
+
+func DefaultBootstrapParamsConfig() *BootstrapParamsConfig {
+	return buildDefaultBootstrapParamsConfig("/dev/null")
+}

pkg/config/xds/bootstrap/default_params_windows.go

@@ -0,0 +1,5 @@
+package bootstrap
+
+func DefaultBootstrapParamsConfig() *BootstrapParamsConfig {
+	return buildDefaultBootstrapParamsConfig("NUL")
+}