Skip to content

Commit

Permalink
fix(kuma-dp): reduce size of access log address (#894)
Browse files Browse the repository at this point in the history
  • Loading branch information
xbauquet authored Jul 15, 2020
1 parent aa95988 commit 2bec835
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 6 deletions.
2 changes: 1 addition & 1 deletion app/kuma-dp/cmd/run.go
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ func newRunCmd() *cobra.Command {
if err != nil {
return err
}
server := accesslogs.NewAccessLogServer(cfg.Dataplane)
server := accesslogs.NewAccessLogServer()

componentMgr := component.NewManager(leader_memory.NewNeverLeaderElector())
if err := componentMgr.Add(server, dataplane); err != nil {
Expand Down
11 changes: 6 additions & 5 deletions app/kuma-dp/pkg/dataplane/accesslogs/server.go
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,8 @@ import (
"github.com/pkg/errors"
"google.golang.org/grpc"

kumadp "github.com/kumahq/kuma/pkg/config/app/kuma-dp"
"github.com/kumahq/kuma/pkg/core"
"github.com/kumahq/kuma/pkg/core/runtime/component"
"github.com/Kong/kuma/pkg/core"
"github.com/Kong/kuma/pkg/core/runtime/component"
)

var logger = core.Log.WithName("accesslogs-server")
Expand All @@ -32,11 +31,13 @@ func (s *accessLogServer) NeedLeaderElection() bool {
return false
}

func NewAccessLogServer(dataplane kumadp.Dataplane) *accessLogServer {
func NewAccessLogServer() *accessLogServer {
id := core.NewUUID()
var address = fmt.Sprintf("/tmp/%s.sock", id)
return &accessLogServer{
server: grpc.NewServer(),
newHandler: defaultHandler,
address: fmt.Sprintf("/tmp/kuma-access-logs-%s-%s.sock", dataplane.Name, dataplane.Mesh),
address: address,
}
}

Expand Down

0 comments on commit 2bec835

Please sign in to comment.