route transition revision #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
January 20, 2020 16:29
…ional handling in the data overview component to better match Kong Admin's functionality.
…e loading animation for data to make the UX more consistent, and to also prevent the jarring flash of content when switching through quickly. tightened up conditional checks for different states on the DataOverview component.
added 2 commits
January 22, 2020 16:34
…ross all detail and YAML views. removed a state from the dataplane detail view that would let the user know if the dataplane was offline.
|
@subnetmarco this PR contains the recent changes you requested, including:
|
jakubdyszkiewicz
approved these changes
Jan 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
disabledstate while data is loading, and also added a small loading icon to it to show that an action is runningThe page transitions were initially there to 1. make the user experience a little smoother and more app-like, and 2. help mask the flashing that occurs when data loads quickly. I've added a delay to each view that will keep the data loading animation present for 500 milliseconds, before displaying the loaded content. This will help provide a more consistent experience, as opposed to one where some pages only display the loading animation for a split second, while others may display it longer.
Here is a video to illustrate the changes more clearly.