feat(*) disable onboarding when no requirement fulfilled to display it #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tomasz Wylężek <tomwylezek@gmail.com>
tomaszwylezek
force-pushed
the
feat/disable-onboarding
branch
from
9a7fbc2 to
aa2debe
Compare
pan-bubr
suggested changes
Aug 11, 2021
Signed-off-by: Tomasz Wylężek <tomwylezek@gmail.com>
pan-bubr
approved these changes
Aug 11, 2021
This was referenced Aug 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We no longer want to display onboarding for users which already have fulfilled the condition to display onboarding popup.
So we are redirecting into onboarding view only if the user has default mesh and no dataplanes and did not seen already the onboarding view. In any other case we are no longer redirecting into onboarding and if user try to open that page it will be redirected into global overview.
Explanation of changes
As right now we have to wait in the router to make sure we can check condition if the page should be displayed or not (so we need to wait till all bootstrap action will be resolved, and
globalLoadingwill change intofalse) it caused a flash of the blank screen after loading is finished (movie below). To avoid that I provided a delay on change on loading inApp.vueto make sure that all calculations done in routing will be finished after that. It is something that will be changed in the future after we change the onboarding.Without delay
Screen.Recording.2021-08-10.at.11.37.28.mov
With delay
Screen.Recording.2021-08-10.at.11.43.00.mov
Signed-off-by: Tomasz Wylężek tomwylezek@gmail.com