Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add a simple test to check PR previews are working #3156

Open
johncowen opened this issue Nov 7, 2024 · 1 comment
Open

add a simple test to check PR previews are working #3156

johncowen opened this issue Nov 7, 2024 · 1 comment
Labels
kind/feature New feature triage/accepted The issue was reviewed and is complete enough to start working on it

Comments

@johncowen
Copy link
Contributor

Description

Very very occasionally we have broken our PR previews without noticing.

It shouldn't be too much trouble to add a browser runner test to ping just one page on the PR preview to make sure its there and working. This way we'd be alerted to if we accidentally broke things there in future.
@johncowen johncowen added triage/pending This issue will be looked at on the next triage meeting kind/feature New feature labels Nov 7, 2024
@johncowen johncowen mentioned this issue Nov 7, 2024
Merged
johncowen added a commit that referenced this issue Nov 11, 2024
@johncowen
fix: pr previews (#3155)
7380c53 
Following #3049 I forgot that our
PRs are ever so slightly different.

This PR applies a similar template interpolation to out index.html for a
build **but only if build is called with `--mode preview`**

At some point I'd like to add some sort of browser runner test to just
ping one page of the GUI on the PR preview to make sure its there and
work to prevent this happening again. I'll make an issue -
#3156

Signed-off-by: John Cowen <john.cowen@konghq.com>
@lukidzi lukidzi added triage/accepted The issue was reviewed and is complete enough to start working on it and removed triage/pending This issue will be looked at on the next triage meeting labels Nov 12, 2024
@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label Feb 11, 2025
@github-actions GitHub Actions
Copy link
Contributor

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant, please comment on it or attend the next triage meeting.

@schogges schogges removed the triage/stale Inactive for some time. It will be triaged again label Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/feature New feature triage/accepted The issue was reviewed and is complete enough to start working on it
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@johncowen @lukidzi @schogges