Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support jest 27 #2171

Merged
merged 1 commit into from
Dec 9, 2020
Merged

feat: support jest 27 #2171

merged 1 commit into from
Dec 9, 2020

Conversation

FauxFaux
Copy link
Contributor

@FauxFaux FauxFaux commented Dec 6, 2020

Summary

  • Adopt changes to work with jest 27

  • Set required jest to 27.0.0-next.2. Later when jest releases 27.0.0, we need to update required version to be 27.0.0. For now we can temporarily publish with current required version for next tag

Does this PR introduce a breaking change?

Ohhhhh yeah.

@ahnpnl
Copy link
Collaborator

ahnpnl commented Dec 6, 2020

Yes there are a few breaking changes for transformer requiring some changes in TsJestTransformer

package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Show resolved Hide resolved
@ahnpnl
Copy link
Collaborator

ahnpnl commented Dec 6, 2020

The version checking should be changed too

Jest = '>=26 <27',

If you correct all the comments above + adjust tests, I think that should be enough

@ahnpnl ahnpnl changed the title feature request: run on jest 27 feat: support jest 27 Dec 7, 2020
@ahnpnl ahnpnl force-pushed the feat/jest-27 branch 5 times, most recently from 5930de8 to 040652c Compare December 8, 2020 15:44
@coveralls
Copy link

coveralls commented Dec 8, 2020

Pull Request Test Coverage Report for Build 409095633

  • 10 of 10 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.06%) to 93.59%

Totals Coverage Status
Change from base Build 407635484: -0.06%
Covered Lines: 940
Relevant Lines: 970

💛 - Coveralls

@ahnpnl ahnpnl marked this pull request as ready for review December 8, 2020 15:57
Copy link
Collaborator

@ahnpnl ahnpnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

global.gc is not exposed. jest-jasmine doesn't report correctly error while jest-circus does, see more information here jestjs/jest#9882

it(`should report correct line numbers`, () => {
// TODO: Refactor e2e tests to have more stable tests.
// eslint-disable-next-line jest/no-disabled-tests
it.skip(`should report correct line numbers`, () => {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this test is flaky. We need to improve e2e tests setup.

@ahnpnl
Copy link
Collaborator

ahnpnl commented Dec 8, 2020

@kulshekhar I think we are good in compatibility with jest 27 for this PR.

@ahnpnl ahnpnl added the 💣 Breaking Changes Includes a breaking change and should probably wait until we're preparing for the release of a major label Dec 8, 2020
@ahnpnl ahnpnl force-pushed the feat/jest-27 branch 2 times, most recently from 9546334 to 1002708 Compare December 8, 2020 20:17
BREAKING CHANGE
Require minimum jest 27
Copy link
Owner

@kulshekhar kulshekhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ahnpnl this looks good 👍
@FauxFaux thank you for initiating this effort!

@ahnpnl ahnpnl merged commit 9909b9d into kulshekhar:master Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💣 Breaking Changes Includes a breaking change and should probably wait until we're preparing for the release of a major
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants