New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(devs-infra): remove ! on realpath of LanguageService #1783

Merged

ahnpnl merged 1 commit into kulshekhar:master from ahnpnl:compiler-improvement

Jul 7, 2020

Collaborator

ahnpnl commented Jul 7, 2020

Summary

Add an undefined checked for realpath of LanguageService

Test plan

Green CI

Does this PR introduce a breaking change?

Yes
No

Other information

N.A.


          chore(devs-infra): remove ! on realpath

22b612e

ahnpnl requested a review from kulshekhar as a code owner

July 7, 2020 12:11

coveralls commented Jul 7, 2020

Pull Request Test Coverage Report for Build 5281

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.008%) to 92.857%

Totals
Change from base Build 5280:	0.008%
Covered Lines:	1055
Relevant Lines:	1090

💛 - Coveralls

kulshekhar approved these changes

View reviewed changes

ahnpnl merged commit 5da0da1 into kulshekhar:master

ahnpnl deleted the compiler-improvement branch

July 7, 2020 13:20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet