Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(compiler): use Program as fallback for language service #1380

Closed
wants to merge 15 commits into from
Closed

fix(compiler): use Program as fallback for language service #1380

wants to merge 15 commits into from

Conversation

ahnpnl
Copy link
Collaborator

@ahnpnl ahnpnl commented Feb 10, 2020

Related to #1336

ahnpnl added 15 commits February 8, 2020 13:10
@ahnpnl
chore(util): update tests, types, correct tsconfig build
674e7ba
@ahnpnl
Merge remote-tracking branch 'upstream/master' into chore/update-tests
998297c
@ahnpnl
chore(util): add a simple test for typescript importer
59f8b1b
@ahnpnl
chore(compiler): add LanguageServiceHost type
b7687d8
@ahnpnl
fix(compiler): use Program as fallback for language service
0e8bf3a
@ahnpnl
chore: update snapshots, contributor list
276044f
@ahnpnl
chore(e2e): add e2e test for composite project
252777e
@ahnpnl
chore(e2e): add composite e2e test
65937f4
@ahnpnl
chore(e2e): add composite e2e test
3f09843
@ahnpnl
chore(util): create composite e2e template, rename __workdir_synlink__
862e5c9
@ahnpnl
chore(e2e): update composite e2e snapshot
2f6bad4
@ahnpnl
chore(e2e): add unit test for fallback Program compiling
077e8c0
@ahnpnl
fix: ci failed due to unknown reason
3043a5c
@ahnpnl
chore(e2e): add composite e2e test
a34c853
@ahnpnl
chore(e2e): add composite e2e test
3bd3339
@ahnpnl ahnpnl closed this Feb 10, 2020
@ahnpnl ahnpnl deleted the fix-composite-project branch February 10, 2020 10:12
@coveralls
Copy link

Pull Request Test Coverage Report for Build 3984

  • 19 of 20 (95.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 90.625%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/compiler.ts 19 20 95.0%
Totals Coverage Status
Change from base Build 3972: 0.1%
Covered Lines: 1083
Relevant Lines: 1139
💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ahnpnl @coveralls