Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: config:init should create ESM version of jest.config.js when type = module #4012

Closed
pointlessrapunzel opened this issue Feb 1, 2023 · 3 comments · Fixed by #4210
Closed
Labels
🚀 Feature Request new suggested feature

Comments

@pointlessrapunzel
Copy link

Version

29.0.5

Steps to reproduce

  1. Create an npm project that has "type": "module" in its package.json
  2. Install jest, typescript, and ts-jest
  3. Run config:init script to generate jest.config.js
  4. Run jest
yarn create vite --template vanilla-ts esm-config-ts-jest
cd esm-config-ts-jest
yarn add jest @types/jest ts-jest
yarn ts-jest config:init
yarn jest

Expected behavior

Jest reads the config file and runs normally if tests found.

Actual behavior

Jest can't read the config file because:
ReferenceError: module is not defined in ES module scope

Debug log

n/a

Additional context

It's not the biggest bug, and can easily be fixed manually, by changing the generated jest.config.js to ESM. But it would be nice if it just worked out of the box.
It should be a simple fix in the cli/config/init.ts script, I can make a PR if it's okay.

Environment

System:
  OS: Linux 4.4 Ubuntu 20.04.5 LTS (Focal Fossa)
  CPU: (12) x64 AMD Ryzen 5 5600H with Radeon Graphics         
Binaries:
  Node: 19.2.0 - ~/.nvm/versions/node/v19.2.0/bin/node
  Yarn: 3.4.1 - ~/.nvm/versions/node/v19.2.0/bin/yarn
  npm: 8.19.3 - ~/.nvm/versions/node/v19.2.0/bin/npm
npmPackages:
  jest: ^29.4.1 => 29.4.1
@ahnpnl
Copy link
Collaborator

ahnpnl commented Feb 1, 2023

PR is welcome :)

@Pamplemousse
Copy link

It's not the biggest bug, and can easily be fixed manually, by changing the generated jest.config.js to ESM.

It would have been nice to show how, for those of us who have this bug and are looking to fix it.

@pointlessrapunzel
Copy link
Author

It's not the biggest bug, and can easily be fixed manually, by changing the generated jest.config.js to ESM.

It would have been nice to show how, for those of us who have this bug and are looking to fix it.

You can either change the config's extension to .cjs,

or change

module.exports = {
// config
}

to ESM (any requires should also be changed to import statements)

export default {
// same config
}

@ahnpnl ahnpnl added 🚀 Feature Request new suggested feature and removed Bug Report Needs Triage labels Apr 2, 2023
Vylpes pushed a commit to Vylpes/card-drop that referenced this issue Jun 3, 2024
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [ts-jest](https://kulshekhar.github.io/ts-jest) ([source](https://github.com/kulshekhar/ts-jest)) | dependencies | patch | [`29.1.3` -> `29.1.4`](https://renovatebot.com/diffs/npm/ts-jest/29.1.3/29.1.4) |

---

### Release Notes

<details>
<summary>kulshekhar/ts-jest (ts-jest)</summary>

### [`v29.1.4`](https://github.com/kulshekhar/ts-jest/blob/HEAD/CHANGELOG.md#2914-2024-05-28)

[Compare Source](kulshekhar/ts-jest@v29.1.3...v29.1.4)

##### Bug Fixes

-   fix(transformer): allow transforming of .cts/.mts extensions. ([#&#8203;3996](kulshekhar/ts-jest#3996)) ([b8f6eaa](kulshekhar/ts-jest@b8f6eaa)), closes [#&#8203;3996](kulshekhar/ts-jest#3996)

##### Features

-   feat: make cli generate esm config based on `type: "module"` ([#&#8203;4210](kulshekhar/ts-jest#4210)) ([81a5f64](kulshekhar/ts-jest@81a5f64)), closes [#&#8203;4210](kulshekhar/ts-jest#4210) [#&#8203;4012](kulshekhar/ts-jest#4012)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4wLjAiLCJ1cGRhdGVkSW5WZXIiOiIzNy4wLjAiLCJ0YXJnZXRCcmFuY2giOiJkZXZlbG9wIn0=-->

Reviewed-on: https://git.vylpes.xyz/External/card-drop/pulls/255
Co-authored-by: Renovate Bot <renovate@vylpes.com>
Co-committed-by: Renovate Bot <renovate@vylpes.com>
Vylpes pushed a commit to Vylpes/vylbot-app that referenced this issue Jun 25, 2024
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [ts-jest](https://kulshekhar.github.io/ts-jest) ([source](https://github.com/kulshekhar/ts-jest)) | dependencies | patch | [`29.1.2` -> `29.1.5`](https://renovatebot.com/diffs/npm/ts-jest/29.1.2/29.1.5) |

---

### Release Notes

<details>
<summary>kulshekhar/ts-jest (ts-jest)</summary>

### [`v29.1.5`](https://github.com/kulshekhar/ts-jest/blob/HEAD/CHANGELOG.md#2915-2024-06-16)

[Compare Source](kulshekhar/ts-jest@v29.1.4...v29.1.5)

##### Bug Fixes

-   build(deps-dev): bump braces ([5560334](kulshekhar/ts-jest@5560334)), ([59026b4](kulshekhar/ts-jest@59026b4)), ([0d9e359](kulshekhar/ts-jest@0d9e359))

### [`v29.1.4`](https://github.com/kulshekhar/ts-jest/blob/HEAD/CHANGELOG.md#2914-2024-05-28)

[Compare Source](kulshekhar/ts-jest@v29.1.3...v29.1.4)

##### Bug Fixes

-   fix(transformer): allow transforming of .cts/.mts extensions. ([b8f6eaa](kulshekhar/ts-jest@b8f6eaa)), closes [#&#8203;3996](kulshekhar/ts-jest#3996)

##### Features

-   feat: make cli generate esm config based on `type: "module"` ([81a5f64](kulshekhar/ts-jest@81a5f64)), closes [#&#8203;4210](kulshekhar/ts-jest#4210) [#&#8203;4012](kulshekhar/ts-jest#4012)

### [`v29.1.3`](https://github.com/kulshekhar/ts-jest/blob/HEAD/CHANGELOG.md#2913-2024-05-21)

[Compare Source](kulshekhar/ts-jest@v29.1.2...v29.1.3)

##### Bug Fixes

-   add `@jest/transform` as an optional peer dependency ([0ba7f86](kulshekhar/ts-jest@0ba7f86))
-   bring back Node 14 support ([eda56a7](kulshekhar/ts-jest@eda56a7))

##### Performance Improvements

-   remove ts resolved module cache file ([4c88da5](kulshekhar/ts-jest@4c88da5))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4wLjAiLCJ1cGRhdGVkSW5WZXIiOiIzNy4wLjAiLCJ0YXJnZXRCcmFuY2giOiJkZXZlbG9wIn0=-->

Reviewed-on: https://git.vylpes.xyz/RabbitLabs/vylbot-app/pulls/438
Reviewed-by: Vylpes <ethan@vylpes.com>
Co-authored-by: Renovate Bot <renovate@vylpes.com>
Co-committed-by: Renovate Bot <renovate@vylpes.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚀 Feature Request new suggested feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants