Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs to suggest using tsconfig #1242

Closed
NickBolles opened this issue Sep 29, 2019 · 1 comment
Closed

Update docs to suggest using tsconfig #1242

NickBolles opened this issue Sep 29, 2019 · 1 comment

Comments

@NickBolles
Copy link

Issue :

The Paths Mapping section of the documentation suggests using the native node require but this fails with a Syntax Error when

Expected behavior :

Allow comments in TsConfig when mapping paths

Debug log:

log file content
SyntaxError: /home/coder/project/packages/server/tsconfig.json: Unexpected token / in JSON at position 420
    at JSON.parse (<anonymous>)
    at Object.Module._extensions..json (internal/modules/cjs/loader.js:841:27)
    at Module.load (internal/modules/cjs/loader.js:685:32)
    at Function.Module._load (internal/modules/cjs/loader.js:620:12)
    at Module.require (internal/modules/cjs/loader.js:723:19)
    at require (internal/modules/cjs/helpers.js:14:16)
    at Object.<anonymous> (/home/coder/project/packages/server/test/jest-e2e.config.js:6:1)
    at Module._compile (internal/modules/cjs/loader.js:816:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:827:10)
    at Module.load (internal/modules/cjs/loader.js:685:32)

Related (but for core): #139

Suggestion

Update the documentation to suggest using the tsconfig package, which supports all of the features of typescript, including comments and hierarchy searching for the tsconfig.

NickBolles added a commit to NickBolles/ts-jest that referenced this issue Sep 29, 2019
@ahnpnl
Copy link
Collaborator

ahnpnl commented May 3, 2020

Sorry to close this but we don’t think this is necessary to have.

@ahnpnl ahnpnl closed this as completed May 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants