Address collected minor issues #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #81 +/- ##
=========================================
- Coverage 96.6% 96.6% -0.1%
=========================================
Files 35 35
Lines 2652 2651 -1
Branches 468 468
=========================================
- Hits 2563 2561 -2
Misses 70 70
- Partials 19 20 +1
Continue to review full report at Codecov.
|
Failure during simulation was sometimes returning zero due to a result variable being overridden. Bailing out upon first error is more consistent with the existing precedent. This required an adjustment to the computation of PERIODS.mk, since now the number of instructions executed will not be emitted if tsim bails early (such as when the SDL plugin is not loaded).
It does not make sense to silently lose data.
Since we look for an end-of-run instruction now, we do not need this complexity.
The longest supported filename for loading into Icarus Verilog (via simtop.v)
was 100 characters. This was demonstrated to be insufficient when working in a
`git worktree` on macOS.
% make -s --no-print-directory -C hw/icarus -f $PWD/build/arm64-apple-darwin20.4.0/PERIODS.mk -f Makefile run_code_modification VPATH=$PWD/test/op:$PWD/test/run BUILDDIR=$PWD/build/arm64-apple-darwin20.4.0 PLUSARGS_EXTRA=+DUMPENDSTATE
WARNING: ../verilog/ram.v:33: $readmemh: Standard inconsistency, following 1364-2005.
ERROR: ../verilog/ram.v:33: $readmemh: Unable to open default.memh for reading.
Could not load file private/var/folders/x5/z29gc2pj4qq9wgkcm6_lw_hc0000gn/T/tmp.lmxHT9cm/test/run/code_modification.texe
make: *** [run_code_modification] Error 1
Note that the initial slash in the "Could not load file" is missing -- the file
name was too long by one character.
We raise the limit to 4096 characters, which is a common maximum filename
length.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the implementation of #80, improved test regularity (for example, checking exit codes more consistently) caused some changes that do not fit within #80's scope. This pull request collects those changes and some other accumulated miscellany.