chore: FormDialogの内部処理を整理する #5321
Open
+139
−47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yagimushi
force-pushed
the
chore-refactoring-FormDialog
branch
6 times, most recently
from
b4642a8 to
67f0735
Compare
commit: |
yagimushi
force-pushed
the
chore-refactoring-FormDialog
branch
from
67f0735 to
4364bcd
Compare
yagimushi
force-pushed
the
chore-refactoring-FormDialog
branch
from
7ae0086 to
d77fb16
Compare
AtsushiM
commented
Jan 23, 2025
| @@ -24,7 +24,7 @@ export const FormDialog: React.FC<Props & ElementProps> = ({ | |||
| onClickClose, | |||
| onPressEscape = onClickClose, | |||
| responseMessage, | |||
| actionDisabled = false, | |||
| actionDisabled, | |||
There was a problem hiding this comment.
actionDisabledは最終的にButtonのdisabledとして設定されるだけであり、falseを指定する意味が薄かったため、初期化しないように修正しました
AtsushiM
commented
Jan 23, 2025
| if (!props.isOpen) { | ||
| return | ||
| if (props.isOpen) { | ||
| onClickClose() |
There was a problem hiding this comment.
早期returnしていましたが
- 直後の実行の条件を逆転させているだけであり、コードの理解が一手遅れる
- !とreturn分処理が無駄になっている
というデメリットのほうが大きそうだったので調整しています
AtsushiM
commented
Jan 23, 2025
Comment on lines
+88
to
+111
| const calcedResponseStatus = useMemo(() => { | ||
| if (!responseMessage) { | ||
| return { | ||
| isProcessing: false, | ||
| visibleMessage: false, | ||
| } | ||
| } | ||
|
|
||
| if (responseMessage.status === 'processing') { | ||
| return { | ||
| isProcessing: true, | ||
| visibleMessage: false, | ||
| } | ||
| } | ||
|
|
||
| return { | ||
| isProcessing: false, | ||
| visibleMessage: true, | ||
| // HINT: statusがprocessingではない === success or errorであることが確定する | ||
| // success or error の場合、text属性も必ず存在する | ||
| status: responseMessage.status as 'success' | 'error', | ||
| message: (responseMessage as { text: string }).text, | ||
| } | ||
| }, [responseMessage]) |
There was a problem hiding this comment.
responseMessageの取り扱いが煩雑になっているので、扱いやすい形に変換、memo化するようにしました。
他コンポーネントでも同様の変換処理が有るため、別PRでカスタムhookを作成する予定です
AtsushiM
requested review from
yt-ymmt and
uknmr
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
関連URL
概要
変更内容
確認方法