chore: MessageDialogの内部ロジックを整理する #5320
Open
+38
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yagimushi
force-pushed
the
chore-refactoring-MessageDialog
branch
from
1a1921d to
37587af
Compare
commit: |
AtsushiM
commented
Jan 22, 2025
Comment on lines
-27
to
-30
| if (!active) { | ||
| return | ||
| if (active) { | ||
| onClickClose() | ||
| } | ||
| onClickClose() |
There was a problem hiding this comment.
早期returnに意味があるほど複雑なロジックではなく、逆に分かりづらいのでifの条件を整えています
AtsushiM
commented
Jan 22, 2025
|
|
||
| return ( | ||
| // eslint-disable-next-line smarthr/best-practice-for-layouts, smarthr/a11y-heading-in-sectioning-content | ||
| <Stack gap={0} as="section" className={wrapper()}> |
There was a problem hiding this comment.
<Stack gap={0} as="section"> は実質 <Section> と同義であり、余計な内部ロジックが実行されるだけだったので置き換えています
AtsushiM
commented
Jan 22, 2025
Comment on lines
+62
to
+77
| const FooterCluster = React.memo< | ||
| Pick<MessageDialogContentInnerProps, 'onClickClose' | 'decorators'> & { className: string } | ||
| >(({ onClickClose, decorators, className }) => { | ||
| const children = useMemo( | ||
| () => decorators?.closeButtonLabel?.(CLOSE_BUTTON_LABEL) || CLOSE_BUTTON_LABEL, | ||
| [decorators], | ||
| ) | ||
|
|
||
| return ( | ||
| <Cluster as="footer" justify="flex-end" className={className}> | ||
| <Button onClick={onClickClose} className="smarthr-ui-Dialog-closeButton"> | ||
| {children} | ||
| </Button> | ||
| </Cluster> | ||
| ) | ||
| }) |
There was a problem hiding this comment.
closeの関数などもmemo化されたもののため、FooterClusterはDialogの開閉で更新されるのみ、open状態ではほぼmemo化された状態が保てるはずです
AtsushiM
requested review from
oti and
yuzuru-akiyama
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
関連URL
概要
変更内容
確認方法