chore: SortDropdownの内部処理をリファクタリングする #5311
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yagimushi
force-pushed
the
chore-refactoring-SortDropdown
branch
from
fd60537 to
e610f52
Compare
commit: |
yagimushi
force-pushed
the
chore-refactoring-SortDropdown
branch
from
e610f52 to
2da43ca
Compare
AtsushiM
commented
Jan 21, 2025
| @@ -50,21 +54,23 @@ export const useSortDropdown = ({ sortFields, defaultOrder, onApply, decorators | |||
| const [innerSelectedField, setInnerSelectedField] = useState<string>() | |||
| const [innerCheckedOrder, setCheckedInnerOrder] = useState<Props['defaultOrder']>(defaultOrder) | |||
|
|
|||
| useMemo(() => { | |||
| useEffect(() => { | |||
There was a problem hiding this comment.
useMemoのreturnを何も使っておらず、かつ内容の処理が完全に副作用しかないため、useEffectに置き換えました
AtsushiM
commented
Jan 21, 2025
Comment on lines
+84
to
+100
| const newFields = innerFields.map((field) => { | ||
| if (field.label === newLabel) { | ||
| if (!field.selected) { | ||
| return { | ||
| ...field, | ||
| selected: true, | ||
| } | ||
| } | ||
| } else if (field.selected) { | ||
| return { | ||
| ...field, | ||
| selected: false, | ||
| } | ||
| } | ||
|
|
||
| return field | ||
| }) |
There was a problem hiding this comment.
必ず配列内すべてのオブジェクトを置き換えていましたが、必要な場合のみ再生成するようにロジックを変更しています。
AtsushiM
commented
Jan 21, 2025
Comment on lines
+113
to
+115
| const onChangeSortOrderRadio = useCallback<ChangeEventHandler<HTMLInputElement>>((e) => { | ||
| setCheckedInnerOrder(e.currentTarget.value as Props['defaultOrder']) | ||
| }, []) |
There was a problem hiding this comment.
setCheckedInnerOrder をそのまま渡すのではなく、実際に利用する形式に変更しました。
eventからvalue属性を参照することで依存関係がない状態にすることで再生成しないようにしています
AtsushiM
requested review from
moshisora and
hiroki0525
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
関連URL
概要
変更内容
確認方法