fix: SegmentedControl内の選択済み項目でButton[variant=primary]を利用する #5310
+1
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit: |
Qs-F
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
関連URL
概要
SegmentedControlコンポーネントにおいて、チェック済みの項目をホバーしたときの背景色と前景色のカラーコントラスト比が不十分でした。そのため、選択済みの場合は、内部で利用されているButtonコンポーネントでvariant=primaryを利用するように変更しました。これによって、選択済み項目で
shr-bg-main-darkenが当たるようになり、十分なコントラスト比が確保されます。変更内容
確認方法
https://www.chromatic.com/build?appId=63d0ccabb5d2dd29825524ab&number=10084