chore: FormControlのVRTにdangerouslyTitleHiddenの場合を追加する #5307
+13
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit: |
misako0927
reviewed
Jan 21, 2025
| <FormControl | ||
| {...args} | ||
| key={dangerouslyTitleHidden.toString()} | ||
| dangerouslyTitleHidden={dangerouslyTitleHidden} |
There was a problem hiding this comment.
[imo]サブアクションエリアが表示されたままだと、今回の事象である「Fieldset に dangerouslyTitleHidden を設定している場合、title は消えるんだけどマージンは残って謎の余白が生まれる」がチェックできないかなと思うので、dangerouslyTitleHidden設定時にサブアクションエリアも消えるようにした方がいいかなと思いました！
と見比べながらチェックしていたのですが、dangerouslyTitleHiddenが指定されているときにサブアクションエリアが残るのは正しいですか・・・？（ローカルだとdangerouslyTitleHidden設定時にサブアクションエリアが消えているのですが、VRTでは残っているようで混乱しております。実装上は残らなさそうですが・・。）
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
関連URL
概要
変更内容
確認方法