Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(CompactInformationPanel)!: コンポーネントを削除 #5129

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

uknmr
Copy link
Collaborator

@uknmr uknmr commented Nov 21, 2024

関連URL

https://smarthr.atlassian.net/browse/SHRUI-1109

概要

#4949 に沿って Story を見直そうと考えましたが、deprecated かつ NotificationBar[base="base"] で置き換えられるため消します。

変更内容

確認方法

消し漏れがないかの軽いチェックで問題ありません。

@uknmr uknmr requested a review from a team as a code owner November 21, 2024 09:53
@uknmr uknmr requested review from misako0927 and moshisora and removed request for a team November 21, 2024 09:53
Copy link

pkg-pr-new bot commented Nov 21, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/kufu/smarthr-ui@5129

commit: 8749d59

Copy link
Contributor

@s-sasaki-0529 s-sasaki-0529 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍️ わずかにプロダクトで使用されてるようですが、機械的に置き換えが可能なこと、長らく非推奨だったことからGOGOです!

@uknmr uknmr merged commit 15a0453 into master Nov 22, 2024
12 checks passed
@uknmr uknmr deleted the improve-CompactInformationPanel-story branch November 22, 2024 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants