docs: RadioButton の Story を見直し #5063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit: |
s-sasaki-0529
requested changes
Oct 30, 2024
| render: (args) => <RadioButtonPanel {...args} />, | ||
| args: { | ||
| children: 'ラジオボタンパネル', | ||
| }, |
There was a problem hiding this comment.
ここ、as の定義がないと Playground とか Controls 全般でクラッシュしちゃいます ><
s-sasaki-0529
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
関連URL
https://smarthr.atlassian.net/browse/SHRUI-1103
概要
#4949 の方針に沿って RadioButton と RadioButtonPanel の Story を見直しました。
変更内容
確認方法
Storybook や Chromatic で確認してください。