Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(RadioButton): 外部からのidをdefaultIdより優先するように修正 #4948

Merged
merged 1 commit into from
Sep 25, 2024
Merged

fix(RadioButton): 外部からのidをdefaultIdより優先するように修正 #4948

merged 1 commit into from
Sep 25, 2024
+1 −1

Conversation

Qs-F
Copy link
Contributor

@Qs-F Qs-F commented Sep 24, 2024

関連URL

https://kufuinc.slack.com/archives/CGC58MW01/p1727167147526389

概要

  • RadioButton: このPRで外部のidより内部のdefaultIdが優先されてしまっていたのを修正

変更内容

  • RadioButton: このPRで外部のidより内部のdefaultIdが優先されてしまっていたのを修正
  • 当該PRの変更に含まれていた他のコンポーネントでは問題ないことを確認

確認方法

@Qs-F Qs-F marked this pull request as ready for review September 24, 2024 08:51
@Qs-F Qs-F requested a review from a team as a code owner September 24, 2024 08:51
@Qs-F Qs-F requested review from misako0927 and uknmr and removed request for a team September 24, 2024 08:51
@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Sep 24, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/kufu/smarthr-ui@4948

commit: 9a5b246

s-sasaki-0529
s-sasaki-0529 approved these changes Sep 24, 2024
View reviewed changes
Copy link
Contributor

@s-sasaki-0529 s-sasaki-0529 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ひええ、申し訳ないです 🙏
useId 使ってる箇所ほかもやらかしてるのではと思って調べましたが、何故かここだけでした。

@yamish123 yamish123 self-requested a review September 24, 2024 22:40
yamish123
yamish123 approved these changes Sep 24, 2024
View reviewed changes
Copy link
Contributor

@yamish123 yamish123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yuiの当該storyで正しく動作することを確認できました！

@s-sasaki-0529 s-sasaki-0529 merged commit 26f689a into master Sep 25, 2024
10 checks passed
@s-sasaki-0529 s-sasaki-0529 deleted the fix/radiobutton/fix-priority-between-external-id-and-default-id branch September 25, 2024 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@s-sasaki-0529 s-sasaki-0529 s-sasaki-0529 approved these changes

@yamish123 yamish123 yamish123 approved these changes

@misako0927 misako0927 Awaiting requested review from misako0927 misako0927 is a code owner automatically assigned from kufu/group-dev-smarthr-ui-reviewers

@uknmr uknmr Awaiting requested review from uknmr uknmr is a code owner automatically assigned from kufu/group-dev-smarthr-ui-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Qs-F @s-sasaki-0529 @yamish123