feat: アイテムが選択されたときに選択済みかどうかを判定するコールバック関数をオプションで渡せるようにする #4346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wonderfulboyx
requested review from
yt-ymmt and
nabeliwo
and removed request for
a team
nabeliwo
approved these changes
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related URL
https://smarthr.atlassian.net/browse/HNC-36742
Overview
MultiComboBoxに渡したitemsにReact.Elementを渡した際に、itemのインスタンスが変わってしまうと、selectedとみなされてほしいitemがselectedにならないケースがありました。
上記の問題を解決するために、MultiComboBoxの呼び出し側がどんなitemをselectedとしたいのかを記述できるようにcallbackを渡せるようにしました
What I did
アイテムが選択されたときに選択済みかどうかを判定するコールバック関数をオプションで渡せるようにしました。
既存の挙動に影響を与えないよう、callbackで渡すようにしています。
Capture