wkhtmltopdf #327
Merged
wkhtmltopdf #327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR aims to add support for wkhtmltopdf as well as CJK and emoji fonts to generate OGP images. The changes include updating container environment variables in the deployment configuration.
- Added a new "clear" environment block with a PORT value in config/deploy.yml.
Files not reviewed (1)
- Dockerfile: Language not supported
Comments suppressed due to low confidence (1)
config/deploy.yml:25
- [nitpick] The key 'clear' in the environment configuration is ambiguous. Consider renaming it to a more descriptive term (e.g., 'override_env' or 'default_env') to clarify its purpose.
clear:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
features
Add wkhtmltopdf , CJK and emoji fonts to Dockerfile to generate OGP images.