Open new window when share api is not provided. #325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a fallback behavior for cases where the Web Share API is not supported, by opening a new window instead of displaying an alert message.
- Changed fallback behavior from alert to opening a new window.
- Updated share controller logic to invoke window.open with the provided URL.
Comments suppressed due to low confidence (1)
app/javascript/controllers/share_controller.js:17
- Replacing the alert with a window.open call alters the user feedback mechanism; consider verifying that this.urlValue is a well-formed URL to prevent potential runtime issues if an invalid value is provided.
window.open(this.urlValue, "_blank")
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.