Skip to content

Commit

Permalink
Update config file change the block id attribute
Browse files Browse the repository at this point in the history
  • Loading branch information
kudashevs committed Aug 11, 2023
1 parent 2e64c76 commit aaf9294
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 7 deletions.
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ ShareButtons::page('https://site.com', 'Page title', [

The code above will result into the following HTML code:
```html
<div id="social-links">
<div id="social-buttons">
<ul>
<li><a href="https://www.facebook.com/sharer/sharer.php?u=https%3A%2F%2Fsite.com&quote=Page+title" class="social-button" title="Page title" rel="nofollow noopener noreferrer"><span class="fab fa-facebook-square"></span></a></li>
<li><a href="https://www.linkedin.com/sharing/share-offsite?mini=true&url=https%3A%2F%2Fsite.com&title=Page+title&summary=" class="social-button" title="Page title" rel="follow"><span class="fab fa-linkedin"></span></a></li>
Expand Down Expand Up @@ -220,7 +220,7 @@ All of the available configuration settings are located in the `config/share-but

### Representation section
```
'block_prefix' => 'value' # Sets a block prefix (default is <div id="social-links"><ul>)
'block_prefix' => 'value' # Sets a block prefix (default is <div id="social-buttons"><ul>)
'block_suffix' => 'value' # Sets a block suffix (default is </ul></div>)
'element_prefix' => 'value' # Sets an element prefix (default is <li>)
'element_suffix' => 'value' # Sets an element suffix (default is </li>)
Expand Down
2 changes: 1 addition & 1 deletion config/share-buttons.php
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
|
*/

'block_prefix' => '<div id="social-links"><ul>',
'block_prefix' => '<div id="social-buttons"><ul>',
'block_suffix' => '</ul></div>',
'element_prefix' => '<li>',
'element_suffix' => '</li>',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ public function provideDifferentDifferentPresentationOptions(): array
return [
'block_prefix results in the default' => [
'getBlockPrefix',
'<div id="social-links"><ul>',
'<div id="social-buttons"><ul>',
],
'block_suffix results in the default' => [
'getBlockSuffix',
Expand Down
6 changes: 3 additions & 3 deletions tests/Unit/ShareButtonsTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -242,15 +242,15 @@ public function it_can_return_multiple_links_and_then_multiple_links_another_tim
->twitter()
->linkedin();

$expected = '<div id="social-links"><ul><li><a href="https://www.facebook.com/sharer/sharer.php?u=https%3A%2F%2Fmysite.com&quote=My+first+title" class="social-button"><span class="fab fa-facebook-square"></span></a></li><li><a href="https://twitter.com/intent/tweet?text=My+first+title&url=https%3A%2F%2Fmysite.com" class="social-button"><span class="fab fa-twitter"></span></a></li><li><a href="https://www.linkedin.com/sharing/share-offsite?mini=true&url=https%3A%2F%2Fmysite.com&title=My+first+title&summary=" class="social-button"><span class="fab fa-linkedin"></span></a></li></ul></div>';
$expected = '<div id="social-buttons"><ul><li><a href="https://www.facebook.com/sharer/sharer.php?u=https%3A%2F%2Fmysite.com&quote=My+first+title" class="social-button"><span class="fab fa-facebook-square"></span></a></li><li><a href="https://twitter.com/intent/tweet?text=My+first+title&url=https%3A%2F%2Fmysite.com" class="social-button"><span class="fab fa-twitter"></span></a></li><li><a href="https://www.linkedin.com/sharing/share-offsite?mini=true&url=https%3A%2F%2Fmysite.com&title=My+first+title&summary=" class="social-button"><span class="fab fa-linkedin"></span></a></li></ul></div>';

$this->assertEquals($expected, (string)$result);

$result = $this->share->page('https://mysite.com', 'My second title')
->reddit()
->telegram();

$expected = '<div id="social-links"><ul><li><a href="https://www.reddit.com/submit?title=My+second+title&url=https%3A%2F%2Fmysite.com" class="social-button"><span class="fab fa-reddit"></span></a></li><li><a href="https://telegram.me/share/url?url=https%3A%2F%2Fmysite.com&text=My+second+title" class="social-button" target="_blank"><span class="fab fa-telegram"></span></a></li></ul></div>';
$expected = '<div id="social-buttons"><ul><li><a href="https://www.reddit.com/submit?title=My+second+title&url=https%3A%2F%2Fmysite.com" class="social-button"><span class="fab fa-reddit"></span></a></li><li><a href="https://telegram.me/share/url?url=https%3A%2F%2Fmysite.com&text=My+second+title" class="social-button" target="_blank"><span class="fab fa-telegram"></span></a></li></ul></div>';

$this->assertEquals($expected, (string)$result);
}
Expand Down Expand Up @@ -288,7 +288,7 @@ public function it_can_return_multiple_links_with_provided_arguments()
->linkedin(['summary' => 'Test summary', 'class' => 'active'])
->twitter(['rel' => 'follow']);

$expected = '<div id="social-links"><ul><li><a href="https://www.facebook.com/sharer/sharer.php?u=https%3A%2F%2Fmysite.com&quote=Page+share+title" class="social-button" rel="nofollow"><span class="fab fa-facebook-square"></span></a></li><li><a href="https://www.linkedin.com/sharing/share-offsite?mini=true&url=https%3A%2F%2Fmysite.com&title=Page+share+title&summary=Test+summary" class="social-button active"><span class="fab fa-linkedin"></span></a></li><li><a href="https://twitter.com/intent/tweet?text=Page+share+title&url=https%3A%2F%2Fmysite.com" class="social-button" rel="follow"><span class="fab fa-twitter"></span></a></li></ul></div>';
$expected = '<div id="social-buttons"><ul><li><a href="https://www.facebook.com/sharer/sharer.php?u=https%3A%2F%2Fmysite.com&quote=Page+share+title" class="social-button" rel="nofollow"><span class="fab fa-facebook-square"></span></a></li><li><a href="https://www.linkedin.com/sharing/share-offsite?mini=true&url=https%3A%2F%2Fmysite.com&title=Page+share+title&summary=Test+summary" class="social-button active"><span class="fab fa-linkedin"></span></a></li><li><a href="https://twitter.com/intent/tweet?text=Page+share+title&url=https%3A%2F%2Fmysite.com" class="social-button" rel="follow"><span class="fab fa-twitter"></span></a></li></ul></div>';
$this->assertEquals($expected, (string)$result);
}

Expand Down

0 comments on commit aaf9294

Please sign in to comment.