Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yaml-testsuite implementation #39

Merged
merged 16 commits into from
Dec 20, 2024
Merged

yaml-testsuite implementation #39

merged 16 commits into from
Dec 20, 2024

Conversation

sencrash
Copy link
Contributor

@sencrash sencrash commented Jun 9, 2024

Resolves #16, supersedes #19

Adds yaml-testsuite as a submodule and enables generating and running the tests with the -Denable-spec-tests flag

Currently the testrunner misreports the number of passed testcases (related to ziglang/zig#1356)

@sencrash
Copy link
Contributor Author

sencrash commented Sep 6, 2024

Is there anything I can do to get this merged?

Copy link
Owner

@kubkon kubkon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this and apologies for the wait. Would you mind rebasing on top of latest main and making sure everything still builds? Also, is it possible to enable testing of the spec on every CI run?

@sencrash sencrash force-pushed the main branch 3 times, most recently from 418be25 to 97f09be Compare October 22, 2024 10:17
@sencrash
Copy link
Contributor Author

Thank you for this and apologies for the wait. Would you mind rebasing on top of latest main and making sure everything still builds? Also, is it possible to enable testing of the spec on every CI run?

Added the spec tests as a CI job, but assert crashes the testrunner so we can only really look at the overall pass/fail

@sencrash sencrash requested a review from kubkon October 22, 2024 10:28
@kubkon
Copy link
Owner

kubkon commented Dec 20, 2024

Exciting! I finally have some time to look into it and so will do my best to work with you on getting it merged in the coming days. Sorry for the wait!

@kubkon kubkon merged commit b3cc3a3 into kubkon:main Dec 20, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

YAML 1.2 compatibility tests
2 participants