Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(qrm): add nic selection result annotation #767

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

luomingmeng
Copy link
Collaborator

@luomingmeng luomingmeng commented Jan 16, 2025

What type of PR is this?

Features

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

@luomingmeng luomingmeng force-pushed the dev/add-nic-selection-result-annotation branch from 3073765 to cf07b6d Compare January 16, 2025 13:20
@luomingmeng luomingmeng self-assigned this Jan 16, 2025
@luomingmeng luomingmeng changed the title add nic selection result annotation feat(qrm): add nic selection result annotation Jan 16, 2025
@luomingmeng luomingmeng force-pushed the dev/add-nic-selection-result-annotation branch 2 times, most recently from 8f256d4 to 6f74065 Compare January 17, 2025 02:40
Copy link

codecov bot commented Jan 17, 2025

Codecov Report

Attention: Patch coverage is 53.46535% with 141 lines in your changes missing coverage. Please review.

Project coverage is 60.60%. Comparing base (24c642f) to head (22012fb).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...g/agent/qrm-plugins/network/staticpolicy/policy.go 62.99% 32 Missing and 15 partials ⚠️
pkg/agent/qrm-plugins/commonstate/state.go 27.27% 16 Missing ⚠️
pkg/agent/qrm-plugins/network/state/state.go 28.57% 11 Missing and 4 partials ⚠️
...qrm-plugins/util/reactor/pod_allocation_reactor.go 50.00% 10 Missing and 5 partials ⚠️
...ork/staticpolicy/reactor/nic_allocation_reactor.go 62.85% 9 Missing and 4 partials ⚠️
...y/dynamicpolicy/reactor/numa_allocation_reactor.go 57.14% 6 Missing and 3 partials ⚠️
...g/agent/qrm-plugins/memory/dynamicpolicy/policy.go 0.00% 5 Missing and 1 partial ⚠️
pkg/agent/qrm-plugins/network/staticpolicy/util.go 57.14% 5 Missing and 1 partial ⚠️
pkg/agent/qrm-plugins/util/util.go 37.50% 4 Missing and 1 partial ⚠️
pkg/util/external/network/manager.go 0.00% 3 Missing ⚠️
... and 3 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #767      +/-   ##
==========================================
- Coverage   60.72%   60.60%   -0.13%     
==========================================
  Files         604      606       +2     
  Lines       63438    63656     +218     
==========================================
+ Hits        38522    38576      +54     
- Misses      21062    21206     +144     
- Partials     3854     3874      +20     
Flag Coverage Δ
unittest 60.60% <53.46%> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@luomingmeng luomingmeng force-pushed the dev/add-nic-selection-result-annotation branch 3 times, most recently from 71ecc19 to 683ae8b Compare January 17, 2025 09:25
@luomingmeng luomingmeng force-pushed the dev/add-nic-selection-result-annotation branch 3 times, most recently from 793197b to 7ddb88f Compare February 8, 2025 07:57
@luomingmeng luomingmeng requested a review from gary-lgy as a code owner February 8, 2025 07:57
@luomingmeng luomingmeng force-pushed the dev/add-nic-selection-result-annotation branch 4 times, most recently from ead7196 to 2218c0c Compare February 10, 2025 13:11
@luomingmeng luomingmeng requested a review from caohe as a code owner February 10, 2025 13:11
@luomingmeng luomingmeng force-pushed the dev/add-nic-selection-result-annotation branch 3 times, most recently from fcb8037 to 397a044 Compare February 11, 2025 08:31
@luomingmeng luomingmeng force-pushed the dev/add-nic-selection-result-annotation branch from 397a044 to 22012fb Compare February 11, 2025 08:33
@luomingmeng luomingmeng force-pushed the dev/add-nic-selection-result-annotation branch from 742555a to ec5174f Compare February 13, 2025 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants