Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add node numa metric emitter and support memory bandwidth related metric #740

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

luomingmeng
Copy link
Collaborator

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

@luomingmeng luomingmeng force-pushed the dev/support-numa-level-metric-emitter branch 4 times, most recently from 349b036 to 1774931 Compare December 16, 2024 02:41
Copy link

codecov bot commented Dec 16, 2024

Codecov Report

Attention: Patch coverage is 71.73913% with 13 lines in your changes missing coverage. Please review.

Project coverage is 56.29%. Comparing base (c1ff5df) to head (91ebf27).
Report is 32 commits behind head on main.

Files with missing lines Patch % Lines
...sadvisor/plugin/metric-emitter/syncer/node/node.go 80.48% 6 Missing and 2 partials ⚠️
...sysadvisor/metric-emitter/metric_emitter_plugin.go 0.00% 4 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #740      +/-   ##
==========================================
+ Coverage   56.15%   56.29%   +0.14%     
==========================================
  Files         597      597              
  Lines       68027    68104      +77     
==========================================
+ Hits        38198    38337     +139     
+ Misses      25798    25724      -74     
- Partials     4031     4043      +12     
Flag Coverage Δ
unittest 56.29% <71.73%> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@luomingmeng luomingmeng force-pushed the dev/support-numa-level-metric-emitter branch 4 times, most recently from f796de0 to a799e81 Compare December 16, 2024 08:53
@luomingmeng luomingmeng force-pushed the dev/support-numa-level-metric-emitter branch from a799e81 to 91ebf27 Compare December 16, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant