tests: fix failing e2e test #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viccuad
approved these changes
Aug 1, 2023
There was a problem hiding this comment.
LGTM. We didn't catch it, and it surprises me that e2e tests for go policies are not run by the reusable workflow:
https://github.com/kubewarden/github-actions/blob/main/.github/workflows/reusable-test-policy-go.yml#L25
Maybe we could open a card about it. Something mirroring the rust workflow, and adding a no-op make e2e-tests to go policies that miss it, or set make tests to depend on make e2e-tests.
Signed-off-by: Fabrizio Sestito <fabrizio.sestito@suse.com>
fabriziosestito
force-pushed
the
fix/e2e-tests
branch
from
0498513
to
ef6489e
Compare
flavio
approved these changes
Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes failing e2e tests due to a change in the error message when a regexp is not valid.
Test
Yes
Additional Information
Potential improvement
Shouldn't the CI catch this when opening a PR?