-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: automatic TLS certificate reload #826
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #826 +/- ##
==========================================
+ Coverage 58.45% 61.44% +2.99%
==========================================
Files 17 17
Lines 994 1035 +41
==========================================
+ Hits 581 636 +55
+ Misses 413 399 -14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! As far as testing goes, we could write an integration test. However, I don't see this as critical and will be fine leaving this part untested.
UPDATE: all done I've updated the code to have an integration test. The integration test will fail until I do the following changes:
|
When running on Linux, monitor changes done to the TLS certificate and key used by the https server. When both change, react by updating the TLS configuration. This allows to rotate the TLS certificate used by a Policy Server without having to restart the process. Signed-off-by: Flavio Castelli <fcastelli@suse.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀
When running on Linux, monitor changes done to the TLS certificate and key used by the https server.
When both change, react by updating the TLS configuration.
This allows to rotate the TLS certificate used by a Policy Server without having to restart the process.
Notes: