fix: wrong certificates validity duration #517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The validity duration for the root CA and other certificate generated in the webhooks.yaml are inverted. In the current code, the root CA expiration is less than the certificate used by the controller, which is signed by the root CA. However, the root CA validity should be 10 years (3650 days) and the certificate used by the controller webserver should be 1 year (365 days). This commit fixes the issue by inverting the validity duration in both certificates. Signed-off-by: José Guilherme Vanz <jguilhermevanz@suse.com>
fabriziosestito
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The validity duration for the root CA and other certificate generated in the webhooks.yaml are inverted. In the current code, the root CA expiration is less than the certificate used by the controller, which is signed by the root CA. However, the root CA validity should be 10 years (3650 days) and the certificate used by the controller webserver should be 1 year (365 days). This commit fixes the issue by inverting the validity duration in both certificates.
Related to kubewarden/kubewarden-controller#7