Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] remove dependency on cert-manager #305

Closed
wants to merge 1 commit into from

Conversation

kranurag7
Copy link

  • remove dependency from cert-manager
  • use helm genCA functions to get a self-signed certificate and reference the same in webhooks.

Description

Fix kubewarden/kubewarden-controller#422 (attempts to fix)

Test

To test this pull request, you can run the following commands:

$ cd charts/kubewarden-controller
$ helm template . > manifest.yaml
$ kubectl apply -f manifest.yaml

Additional Information

Tradeoff

Potential improvement

use helm genCA functions to get a self-signed certificate and reference
the same in webhooks.

Signed-off-by: Anurag <contact.anurag7@gmail.com>
@jvanz
Copy link
Member

jvanz commented Sep 25, 2023

Hi @kranurag7 ! Thanks for the initiative to work on this issue. However, we decided to follow another approach and manage the certificate in the controller. Therefore, this change is not necessary.

I would like to say sorry if the change on how we will manage the CA is not clear in the issues. And making you spend time on this.

@jvanz jvanz closed this Sep 25, 2023
@kranurag7 kranurag7 deleted the helm-certs branch September 26, 2023 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Feature Request: make cert-manager optional
2 participants