Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add telemetry.tracing.jaeger.tls.insecure #136

Merged
merged 2 commits into from
Oct 11, 2022
Merged

feat: Add telemetry.tracing.jaeger.tls.insecure #136

merged 2 commits into from
Oct 11, 2022

Conversation

viccuad
Copy link
Member

@viccuad viccuad commented Oct 11, 2022

Description

feat: Add telemetry.tracing.jaeger.tls.insecure.

Relates to kubewarden/kubewarden-controller#304 (comment).

Test

To test this pull request, you can run the following commands:

helm template . --show-only templates/opentelemetry-collector.yaml \
  --set telemetry.enabled=true --set telemetry.tracing.jaeger.endpoint=true \
  --set telemetry.tracing.jaeger.tls.insecure=true

helm template . --show-only templates/opentelemetry-collector.yaml \
  --set telemetry.enabled=true --set telemetry.tracing.jaeger.endpoint=true

@viccuad
feat: Add telemetry.tracing.jaeger.tls.insecure
3a25aac 
Signed-off-by: Víctor Cuadrado Juan <vcuadradojuan@suse.de>
@viccuad viccuad requested a review from a team as a code owner October 11, 2022 09:24
@viccuad viccuad mentioned this pull request Oct 11, 2022
Merged
@viccuad
build: Bump kubewarden-controller to 1.2.2
cc813d9 
Signed-off-by: Víctor Cuadrado Juan <vcuadradojuan@suse.de>
@viccuad viccuad self-assigned this Oct 11, 2022
@viccuad viccuad mentioned this pull request Oct 11, 2022
Merged
raulcabello
raulcabello approved these changes Oct 11, 2022
View reviewed changes
Copy link
Contributor

@raulcabello raulcabello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@viccuad viccuad merged commit 0c0ea3b into kubewarden:main Oct 11, 2022
@viccuad
Copy link
Member Author

viccuad commented Oct 11, 2022

kubewarden-controller 1.2.2 succesfully released!

@viccuad viccuad deleted the jaeger-tls-insecure branch August 1, 2023 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raulcabello raulcabello raulcabello approved these changes

Assignees

@viccuad viccuad

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@viccuad @raulcabello