Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reference/artifacts page #472

Merged
merged 2 commits into from
Dec 6, 2024
Merged

Add reference/artifacts page #472

merged 2 commits into from
Dec 6, 2024

Conversation

viccuad
Copy link
Member

@viccuad viccuad commented Dec 5, 2024

Description

Test

Additional Information

Tradeoff

Potential improvement

@viccuad viccuad requested a review from a team as a code owner December 5, 2024 16:59
Copy link

netlify bot commented Dec 5, 2024

Deploy Preview for silly-bunny-8cedd0 ready!

Name Link
🔨 Latest commit 23264d7
🔍 Latest deploy log https://app.netlify.com/sites/silly-bunny-8cedd0/deploys/6752b444915528000889b9e0
😎 Deploy Preview https://deploy-preview-472--silly-bunny-8cedd0.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@kkaempf kkaempf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, this PR seems to mix multiple changes beyond adding the artifacts page ?! 🤔

Copy link
Member

@flavio flavio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new content looks good, but it looks like you built the PR on top of another one. Can you rebase against the main branch?

Signed-off-by: Víctor Cuadrado Juan <vcuadradojuan@suse.de>
Signed-off-by: Víctor Cuadrado Juan <vcuadradojuan@suse.de>
@viccuad
Copy link
Member Author

viccuad commented Dec 6, 2024

Argh, you are right, rebased onto main.

Copy link
Member

@flavio flavio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@flavio flavio merged commit a1fda6e into kubewarden:main Dec 6, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants