Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explain different attestations and add missing info for kwctl #462

Merged
merged 2 commits into from
Oct 28, 2024

Conversation

viccuad
Copy link
Member

@viccuad viccuad commented Oct 25, 2024

Description

Relates to kubewarden/kubewarden-controller#856.

Test

Tested commands locally by hand.

Additional Information

Tradeoff

Potential improvement

Signed-off-by: Víctor Cuadrado Juan <vcuadradojuan@suse.de>
@viccuad viccuad self-assigned this Oct 25, 2024
@viccuad viccuad requested a review from a team as a code owner October 25, 2024 13:55
Copy link

netlify bot commented Oct 25, 2024

Deploy Preview for silly-bunny-8cedd0 ready!

Name Link
🔨 Latest commit 5c66edd
🔍 Latest deploy log https://app.netlify.com/sites/silly-bunny-8cedd0/deploys/671f51f37f31b40008f4342b
😎 Deploy Preview https://deploy-preview-462--silly-bunny-8cedd0.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@jhkrug jhkrug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two tiny suggestions if you like them. Otherwise lgtm

docs/tutorials/verifying-kubewarden.md Outdated Show resolved Hide resolved
docs/tutorials/verifying-kubewarden.md Outdated Show resolved Hide resolved
Co-authored-by: John Krug <john.krug@suse.com>
Signed-off-by: Víctor Cuadrado Juan <2196685+viccuad@users.noreply.github.com>
@viccuad
Copy link
Member Author

viccuad commented Oct 28, 2024

Thanks for the review!

@viccuad viccuad merged commit 2a033e3 into kubewarden:main Oct 28, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants