chore: Update Golang to version 1.21 #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubevirt-bot
added
release-note-none
Signed-off-by: Andrej Krejcir <akrejcir@redhat.com>
akrejcir
force-pushed
the
update-golang
branch
from
456f638 to
584f8f5
Compare
codingben
reviewed
Feb 5, 2024
| @@ -151,7 +151,7 @@ var _ = Describe("TLS config", func() { | |||
|
|
|||
| It("should fail if client certificate is not provided", func() { | |||
| _, _, err := httpGet("https://"+testHostname+"/apis/"+api.Group+"/"+api.Version+"/", "", PortForwardClient) | |||
| Expect(err).To(MatchError(ContainSubstring("bad certificate"))) | |||
There was a problem hiding this comment.
Is it part of bumping the golang version?
There was a problem hiding this comment.
Yes, otherwise it would fail CI. I think in the new version, the standard library has changed the TLS error message.
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 0xFelix The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Updated Golang to version
1.21.6Release note: