chore: Update golang version and dependencies #31
Conversation
kubevirt-bot
added
release-note-none
kubevirt-bot
added
the
needs-rebase
|
This PR is waiting on: kubevirt/kubevirt#10972 |
kubevirt-bot
removed
the
needs-rebase
Signed-off-by: Andrej Krejcir <akrejcir@redhat.com>
Signed-off-by: Andrej Krejcir <akrejcir@redhat.com>
go.mod
Outdated
| k8s.io/client-go => k8s.io/client-go v0.26.3 | ||
|
|
||
| // TODO - remove after openshift dependencies stop using the wrong URL | ||
| vbom.ml/util => github.com/fvbommel/util v0.0.3 |
There was a problem hiding this comment.
Is the broken openshift dep still in use? Can you tell where it originates from?
There was a problem hiding this comment.
I've updated the openshift dependencies and now its not used anymore.
kubevirt.io/client-go module was updated to the latest commit in main branch, because it contains needed changes. When a new version of kubevirt.io/client-go is released, we will update go.mod file Signed-off-by: Andrej Krejcir <akrejcir@redhat.com>
| replace k8s.io/client-go => k8s.io/client-go v0.23.5 | ||
| // Replacing these versions because kubevirt.io/client-go requires it. | ||
| replace ( | ||
| k8s.io/api => k8s.io/api v0.26.4 |
There was a problem hiding this comment.
Bump these to latest dot release v0.26.12?
There was a problem hiding this comment.
Because this exact version is used by kubevirt.io/client-go:
https://github.com/kubevirt/client-go/blob/304cdf11f9c46df9f15d1ed980d00b4bddb146b0/go.mod#L79-L104
I will try to post a PR to fix the inconvenient dependencies of kubevirt.io/client-go.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 0xFelix The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
What this PR does / why we need it:
Updated golang to
1.20, and module dependencies.Release note: