chore: Update controller-gen #996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The old version, v0.10.0, failed to run when compiled using golang 1.22. That broke compilation of SSP operator. This commit updates the version to v0.14.0 which is not the latest, because the latest required golang 1.22. We still want to be able to compile SSP using golang 1.21. Signed-off-by: Andrej Krejcir <akrejcir@redhat.com>
kubevirt-bot
added
release-note-none
|
/lgtm |
0xFelix
reviewed
Jun 17, 2024
| documentation for more details: \n remote targets https://github.com/kubernetes-sigs/kustomize/blob/master/examples/remoteBuild.md" | ||
| description: |- | ||
| URL of a remote Kustomize target from which to generate and deploy resources. | ||
|
|
There was a problem hiding this comment.
This adds a lot of unneccessary newlines, can it be avoided?
There was a problem hiding this comment.
I'm not sure how. Maybe there is a config option in the controller-gen. I will check.
There was a problem hiding this comment.
No, there isn't any parameter.
|
/retest |
1 similar comment
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 0xFelix The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The old version,
v0.10.0, failed to run when compiled using golang 1.22. That broke compilation of SSP operator.This PR updates the version to
v0.14.0which is not the latest, because the latest required golang 1.22. We still want to be able to compile SSP using golang 1.21.Release note: