-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Do not force IPv4 on metrics service #957
Conversation
The service that exposes metrics used to force IPv4 protocol. It failed in clusters that have only IPv6. Signed-off-by: Andrej Krejcir <akrejcir@redhat.com>
Quality Gate passedIssues Measures |
Holding until I verify it. |
The CI fails because of: https://issues.redhat.com/browse/CNV-40547 |
/retest |
/unhold |
Please do not block merging on the verification. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
Looks good to me.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 0xFelix The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
/cherry-pick release-v0.20 |
@akrejcir: new pull request created: #965 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherry-pick release-v0.19 |
@akrejcir: new pull request created: #969 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What this PR does / why we need it:
The service that exposes metrics used to force IPv4 protocol. It failed in clusters that have only IPv6.
Fixes: https://issues.redhat.com/browse/CNV-40159
Release note: