Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup: Remove unused tekton and virtioImage code #946

Merged
merged 2 commits into from
Apr 8, 2024
Merged

cleanup: Remove unused tekton and virtioImage code #946

merged 2 commits into from
Apr 8, 2024

Conversation

akrejcir
Copy link
Collaborator

@akrejcir akrejcir commented Apr 3, 2024 •
edited
Loading

What this PR does / why we need it:
This removes minor usages of tekton from these places:

  • CSV generator
  • Environment variables used by operator
  • SSP CR example
  • Default update function for reconcile code
  • SSP CR created by functional tests

Removes unused virtioImage code.

Release note:

None

@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/L labels Apr 3, 2024
@kubevirt-bot kubevirt-bot requested review from 0xFelix and ksimon1 April 3, 2024 13:13
@akrejcir
Copy link
Collaborator Author

akrejcir commented Apr 3, 2024

Probably need to wait with this PR until we change HCO to not use the removed csv-genreator parameters.

@akrejcir
Copy link
Collaborator Author

akrejcir commented Apr 3, 2024

/hold

@kubevirt-bot kubevirt-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 3, 2024
@akrejcir
Copy link
Collaborator Author

akrejcir commented Apr 3, 2024

HCO does not use the parameters.

/unhold

@kubevirt-bot kubevirt-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 3, 2024
@akrejcir
Copy link
Collaborator Author

akrejcir commented Apr 4, 2024

/retest

akrejcir added 2 commits April 4, 2024 13:11
@akrejcir
cleanup: Remove tekton code from various places
ccd25a5 
This removes minor usages of tekton from these places:
- CSV generator
- Environment variables used by operator
- SSP CR example
- Default update function for reconcile code
- SSP CR created by functional tests

Signed-off-by: Andrej Krejcir <akrejcir@redhat.com>
@akrejcir
cleanup: Remove unused virtioImage code
59adc9e 
Signed-off-by: Andrej Krejcir <akrejcir@redhat.com>
@akrejcir akrejcir force-pushed the minor-tekton-cleanup branch from 2781f0d to 59adc9e Compare April 4, 2024 11:21
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Apr 4, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@akrejcir akrejcir changed the title cleanup: Remove tekton code from various places cleanup: Remove unused tekton and virtioImage code Apr 4, 2024
@0xFelix
Copy link
Member

0xFelix commented Apr 4, 2024

What about docs/configuration.md, docs/development.md and

ssp-operator/internal/common/version.go

Line 4 in b717b68

TektonTasksVersion = "v0.17.0"
?

@akrejcir
Copy link
Collaborator Author

akrejcir commented Apr 4, 2024

What about docs/configuration.md, docs/development.md and

ssp-operator/internal/common/version.go

Line 4 in b717b68

TektonTasksVersion = "v0.17.0"

?

The documentation is removed in #945

I missed the version.go file, thanks for noticing.

0xFelix
0xFelix reviewed Apr 5, 2024
View reviewed changes
Copy link
Member

@0xFelix 0xFelix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

/approve
/retest

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 0xFelix

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 5, 2024
@ksimon1
Copy link
Member

ksimon1 commented Apr 8, 2024

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 8, 2024
@kubevirt-bot kubevirt-bot merged commit 51d8d9f into kubevirt:main Apr 8, 2024
12 checks passed
@akrejcir akrejcir deleted the minor-tekton-cleanup branch August 5, 2024 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ksimon1 ksimon1 ksimon1 left review comments

@0xFelix 0xFelix 0xFelix left review comments

Assignees

@ksimon1 ksimon1

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@akrejcir @0xFelix @kubevirt-bot @ksimon1