Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove workflow: add-reviewer-monitoring.yaml #874

Merged
merged 1 commit into from
Feb 6, 2024

Conversation

akrejcir
Copy link
Collaborator

@akrejcir akrejcir commented Feb 6, 2024

What this PR does / why we need it:
Currently the workflow adds comments to PRs too often.

We will make a better solution in a future PR.

Special notes for your reviewer:
This is a partial PR from: #669

Release note:

None

Currently the workflow adds comments to PRs too often.

We will make a better solution in a future PR.

Signed-off-by: Andrej Krejcir <akrejcir@redhat.com>
@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Feb 6, 2024
Copy link

sonarqubecloud bot commented Feb 6, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@akrejcir
Copy link
Collaborator Author

akrejcir commented Feb 6, 2024

/cc @0xFelix @jcanocan

Copy link
Member

@0xFelix 0xFelix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 0xFelix

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 6, 2024
@jcanocan
Copy link
Contributor

jcanocan commented Feb 6, 2024

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 6, 2024
@kubevirt-bot kubevirt-bot merged commit 9127da9 into kubevirt:main Feb 6, 2024
8 checks passed
@akrejcir akrejcir deleted the remove-monitoring-reviewer branch February 6, 2024 11:32
@kubevirt-bot
Copy link
Contributor

@akrejcir: #874 failed to apply on top of branch "release-v0.19":

Applying: chore: Remove workflow: add-reviewer-monitoring.yaml
Using index info to reconstruct a base tree...
M	.github/workflows/add-reviewer-monitoring.yaml
Falling back to patching base and 3-way merge...
CONFLICT (modify/delete): .github/workflows/add-reviewer-monitoring.yaml deleted in chore: Remove workflow: add-reviewer-monitoring.yaml and modified in HEAD. Version HEAD of .github/workflows/add-reviewer-monitoring.yaml left in tree.
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 chore: Remove workflow: add-reviewer-monitoring.yaml
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-v0.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants