chore: Update vm-console-proxy to v0.7.0 #1135
Conversation
kubevirt-bot
added
release-note
|
Failures look related |
akrejcir
force-pushed
the
update-vm-proxy
branch
from
1fe9026 to
db2685b
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 0xFelix The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
| @@ -141,12 +146,21 @@ func (v *vmConsoleProxy) Reconcile(request *common.Request) ([]common.ReconcileR | |||
| return nil, err | |||
| } | |||
|
|
|||
| var cleanupResults []common.CleanupResult | |||
| oldApiServiceCleanup, err := deleteOldApiService(request) | |||
There was a problem hiding this comment.
How about the v1.token.kubevirt.io APIService, is it somewhere deleted?
There was a problem hiding this comment.
Yes, it's deleted in Cleanup() method, on line 234:
objectsToDelete = append(objectsToDelete,
v.clusterRoleBinding.DeepCopy(),
v.roleBinding.DeepCopy(),
v.apiService.DeepCopy())
cleanupResults, err := common.DeleteAll(request, objectsToDelete...)
|
I've noticed the old API service is not deleted on /hold |
kubevirt-bot
added
the
do-not-merge/hold
This version increased API version to v1. Signed-off-by: Andrej Krejcir <akrejcir@redhat.com>
The TLS for vm-console-proxy can be configured in the ConfigMap that the project reads. This commit writes a configuration file to the ConfigMap based on the TLS configuration in the SSP object. Signed-off-by: Andrej Krejcir <akrejcir@redhat.com>
akrejcir
force-pushed
the
update-vm-proxy
branch
from
db2685b to
64a8480
Compare
|
|
/unhold |
kubevirt-bot
removed
the
do-not-merge/hold
|
/lgtm |
What this PR does / why we need it:
vm-console-proxytov0.7.0.vm-console-proxy.Release note: