udpn: Add missing error wrapping #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubevirt-bot
added
the
dco-signoff: yes
qinqon
force-pushed
the
udpn-print-errors
branch
from
e73b20d
to
4b41169
Compare
oshoval
approved these changes
Sep 12, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: maiqueb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
qinqon
force-pushed
the
udpn-print-errors
branch
from
4b41169
to
43f775f
Compare
oshoval
reviewed
Sep 12, 2024
| @@ -198,7 +198,7 @@ var _ = Describe("VMI IPAM controller", Serial, func() { | |||
| inputNADs: []*nadv1.NetworkAttachmentDefinition{ | |||
| dummyNADWrongFormat(nadName), | |||
| }, | |||
| expectedError: fmt.Errorf("failed to extract the relevant NAD information"), | |||
| expectedError: fmt.Errorf("failed to extract the relevant NAD information: failed to extract CNI configuration from NAD: invalid character 'h' in literal true (expecting 'r')"), | |||
There was a problem hiding this comment.
nit: if we can omit please the "invalid character 'h' in literal true (expecting 'r')" would be nicer
/lgtm
Signed-off-by: Enrique Llorente <ellorent@redhat.com>
qinqon
force-pushed
the
udpn-print-errors
branch
from
43f775f
to
f75faab
Compare
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
udpn: Add missing error wrapping