Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(test): Add CentOS Stream 10 func test. #305

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

jcanocan
Copy link
Contributor

What this PR does / why we need it:

Adds the required containerdisk infrastructure and a functional test for CentOS Stream 10.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):

Fixes # CNV-52778

Special notes for your reviewer:

Release note:

None

Adds the required containerdisk infrastructure and a functional test
for CentOS Stream 10.

Signed-off-by: Javier Cano Cano <jcanocan@redhat.com>
@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Dec 18, 2024
Copy link
Member

@0xFelix 0xFelix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please create a new lane for this in project-infra.

/approve
/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 18, 2024
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 0xFelix

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 18, 2024
@kubevirt-bot kubevirt-bot merged commit fa6dd42 into kubevirt:main Dec 18, 2024
16 checks passed
@lyarwood
Copy link
Member

/cherry-pick release-1.2

@kubevirt-bot
Copy link
Contributor

@lyarwood: #305 failed to apply on top of branch "release-1.2":

Applying: chore(test): Add CentOS Stream 10 func test.
Using index info to reconstruct a base tree...
M	tests/functests/instancetype_test.go
Falling back to patching base and 3-way merge...
Auto-merging tests/functests/instancetype_test.go
CONFLICT (content): Merge conflict in tests/functests/instancetype_test.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 chore(test): Add CentOS Stream 10 func test.

In response to this:

/cherry-pick release-1.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@lyarwood
Copy link
Member

@jcanocan ^ can you cherry-pick this back to release-1.2 and setup the required lanes?

@jcanocan
Copy link
Contributor Author

@jcanocan ^ can you cherry-pick this back to release-1.2 and setup the required lanes?

Done. Check #308

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants