Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace dots with dashes when renaming VMs #961

Merged
merged 1 commit into from
Jul 21, 2024

Conversation

ahadas
Copy link
Member

@ahadas ahadas commented Jul 21, 2024

No description provided.

Signed-off-by: Arik Hadas <ahadas@redhat.com>
Copy link

codecov bot commented Jul 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 16.26%. Comparing base (40ba756) to head (4741664).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #961      +/-   ##
==========================================
- Coverage   16.30%   16.26%   -0.04%     
==========================================
  Files         103      103              
  Lines       19386    19386              
==========================================
- Hits         3160     3153       -7     
- Misses      15944    15954      +10     
+ Partials      282      279       -3     
Flag Coverage Δ
unittests 16.26% <100.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ahadas ahadas merged commit e2d0e93 into kubev2v:main Jul 21, 2024
10 of 12 checks passed
@ahadas ahadas deleted the rename_dot_dash branch July 21, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants