Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MTV-1495 | Add common arguments for v2v #1072

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

mnecas
Copy link
Member

@mnecas mnecas commented Sep 24, 2024

Issue:
We have two way to run the v2v either the virt-v2v for the cold migration or the virt-v2v-in-place for the warm migration. These commands share a lot of arguments and the virt-v2v-in-place was missing a lot of them which we already have available for the cold migration.

Fix:
Add shared arguments which should be added to both of the commands.

@mnecas mnecas requested a review from yaacov as a code owner September 24, 2024 07:23
@mnecas mnecas force-pushed the add_luks_for_warm branch 4 times, most recently from a1ee8b3 to 429643f Compare September 24, 2024 07:32
@mnecas mnecas changed the title MTV-1495 | Add missing luks keys to the warm migration MTV-1495 | Create a common arguments which should be shared between warm and cold migration Sep 24, 2024
Copy link

sonarcloud bot commented Sep 24, 2024

@mnecas mnecas changed the title MTV-1495 | Create a common arguments which should be shared between warm and cold migration MTV-1495 | Add common arguments for v2v Sep 24, 2024
@codecov-commenter
Copy link

codecov-commenter commented Sep 24, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 33.33333% with 12 lines in your changes missing coverage. Please review.

Project coverage is 16.28%. Comparing base (62b9a07) to head (d220ca7).

Files with missing lines Patch % Lines
virt-v2v/cmd/entrypoint.go 33.33% 10 Missing and 2 partials ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1072      +/-   ##
==========================================
+ Coverage   16.27%   16.28%   +0.01%     
==========================================
  Files         112      112              
  Lines       19787    19788       +1     
==========================================
+ Hits         3220     3223       +3     
+ Misses      16283    16280       -3     
- Partials      284      285       +1     
Flag Coverage Δ
unittests 16.28% <33.33%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Martin Necas <mnecas@redhat.com>
@mnecas mnecas merged commit 10d56ef into kubev2v:main Sep 24, 2024
21 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants