Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐾 Add preserveStaticIPs flag to the plan #1133

Closed
liranr23 opened this issue May 2, 2024 · 7 comments
Closed

🐾 Add preserveStaticIPs flag to the plan #1133

liranr23 opened this issue May 2, 2024 · 7 comments
Assignees
Labels
enhancement Categorizes issue or PR as related to a new feature. plans
Milestone

Comments

@liranr23
Copy link
Member

liranr23 commented May 2, 2024

We added new feature in kubev2v/forklift#852 , to allow the perseverance of the VM static IPs from vSphere provider.
In order to do that, the user needs to specify he wish to preserve it by setting it within the plan:
preserveStaticIPs=true

e.g the plan will look like:

kind: Plan
metadata:
  annotations:
    populatorLabels: 'True'
  creationTimestamp: '2024-01-02T15:15:51Z'
  generation: 1
  name: testcluster
  namespace: konveyor-forklift
  resourceVersion: '7403505'
  uid: 53e13421-6590-49d9-84b0-735abf98e738
spec:
  archived: false
  description: ''
  map:
    network:
      name: testcluster-xzklj
      namespace: konveyor-forklift
    storage:
      name: testcluster-lmqbt
      namespace: konveyor-forklift
  preserveStaticIPs: true
  provider:
    destination:
      name: host
      namespace: konveyor-forklift
    source:
      name: ovirt
      namespace: konveyor-forklift
  targetNamespace: konveyor-forklift
  vms:
    - hooks: []
      id: 41f2988a-a579-40a8-ab25-4584b1f696dc
  warm: false

Implementation should be similar to #803

@liranr23 liranr23 added enhancement Categorizes issue or PR as related to a new feature. plans labels May 2, 2024
@yaacov yaacov modified the milestones: 2.7.0, 2.6.2 May 2, 2024
@yaacov
Copy link
Member

yaacov commented May 2, 2024

@sgratch hi, this is for 2.6.2 so it will take precedence over the 2.7 stuff

@yaacov
Copy link
Member

yaacov commented May 2, 2024

Notes:
a. this is vsphere only
b. when not defined it is false

@liranr23 please keep me honst here, not defined is false ?

@liranr23
Copy link
Member Author

liranr23 commented May 2, 2024

Notes: a. this is vsphere only b. when not defined it is false

@liranr23 please keep me honst here, not defined is false ?

indeed

sgratch added a commit to sgratch/forklift-console-types that referenced this issue May 5, 2024
Reference: kubev2v/forklift-console-plugin#1133

Signed-off-by: Sharon Gratch <sgratch@redhat.com>
sgratch added a commit to sgratch/forklift-console-types that referenced this issue May 5, 2024
Reference: kubev2v/forklift-console-plugin#1133

Signed-off-by: Sharon Gratch <sgratch@redhat.com>
sgratch added a commit to sgratch/forklift-console-types that referenced this issue May 5, 2024
Reference: kubev2v/forklift-console-plugin#1133

Signed-off-by: Sharon Gratch <sgratch@redhat.com>
sgratch added a commit to sgratch/forklift-console-plugin that referenced this issue May 5, 2024
Reference: kubev2v#1133

Add an option to set the preserveStaticIPs flag within the plans details section
for the vSphere provider only.

The default value is preserveStaticIPs=false

Signed-off-by: Sharon Gratch <sgratch@redhat.com>
sgratch added a commit to sgratch/forklift-console-plugin that referenced this issue May 5, 2024
Reference: kubev2v#1133

Add an option to set the preserveStaticIPs flag within the plans details section
for the vSphere provider only.

The default value is preserveStaticIPs=false

Signed-off-by: Sharon Gratch <sgratch@redhat.com>
@yaacov
Copy link
Member

yaacov commented May 5, 2024

addressed by #1138

sgratch added a commit to sgratch/forklift-console-plugin that referenced this issue May 6, 2024
Reference: kubev2v#1133

Signed-off-by: Sharon Gratch <sgratch@redhat.com>
@yaacov
Copy link
Member

yaacov commented May 6, 2024

addressed by #1138 + #1139

@yaacov yaacov closed this as completed May 6, 2024
@ahadas
Copy link
Member

ahadas commented May 15, 2024

@yaacov @sgratch missing backports?

@yaacov
Copy link
Member

yaacov commented May 15, 2024

@yaacov @sgratch missing backports?

should be in 2.6.2 (target is 2.6.2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Categorizes issue or PR as related to a new feature. plans
Projects
None yet
Development

No branches or pull requests

4 participants