-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sever): for test runs, split the failed state into more descriptive statuses #2310
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. One question: with this approach, is it safe to assume that if I get a TRACE_FAILED
state, the trigger stage was correct?
yes. If the trigger fails, the test execution stops |
@jorgeepc exactly. The failed stage means that all the previous steps succedded |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need to update the OpenAPI specs.
@jorgeepc good catch. updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It sounds ok! Before merging it I have one comment about retro compatibility: should we write a migration or handle in separate the old status to avoid problems with early versions of Tracetest?
@@ -180,13 +180,20 @@ const ( | |||
RunStateCreated RunState = "CREATED" | |||
RunStateExecuting RunState = "EXECUTING" | |||
RunStateAwaitingTrace RunState = "AWAITING_TRACE" | |||
RunStateFailed RunState = "FAILED" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Today we save this value on our database, right? How will we keep the retro compatibility with older Tracetest versions?
Should we map the old FAILED
string as always ASSERTION_FAILED
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or even writing a migration to fix it on the database?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wouldn't do a DB migration, it is too error prone. Fallbacking to another stata is better I think. Why do you suggest ASSERTION_FAILED
? not that I have a better one, but to understand the logic of the choice.
This PR makes the TestRun state more accurate by providing a new set of statuses:
TRACE_FAILED
,TRIGGER_FAILED
andASSERTION_FAILED
.Changes
Fixes
Checklist