fix: added more telemetry and log telemetry to console in dev

kubeshop · May 10, 2023 · 77757bc · 77757bc
1 parent 45e8f36
commit 77757bc
Show file tree

Hide file tree

Showing 5 changed files with 19 additions and 9 deletions.
diff --git a/electron/app/ipc/ipcListeners.ts b/electron/app/ipc/ipcListeners.ts
@@ -109,6 +109,8 @@ ipcMain.on('track-event', async (event: any, {eventName, payload}: any) => {
       userId: machineId,
       properties,
     });
+  } else if (process.env.NODE_ENV === `development`) {
+    console.log(`telemetry event ${eventName}`, payload);
   }
 });
 

diff --git a/src/components/molecules/FormEditor/FormEditor.tsx b/src/components/molecules/FormEditor/FormEditor.tsx
@@ -31,7 +31,6 @@ import {parseYamlDocument, stringifyK8sResource} from '@utils/yaml';
 import {isHelmChartFile} from '@shared/utils/helm';
 import {isEqual} from '@shared/utils/isEqual';
 import {isInClusterModeSelector, isInPreviewModeSelector} from '@shared/utils/selectors';
-import {trackEvent} from '@shared/utils/telemetry';
 
 import {FormArrayFieldTemplate} from './FormArrayFieldTemplate';
 import * as S from './FormEditor.styled';
@@ -123,12 +122,6 @@ const FormEditor: React.FC<IProps> = props => {
       }
     };
     loadResourceFile();
-
-    return () => {
-      if (selectedResource || selectedFilePath) {
-        trackEvent('edit/form_editor', {resourceKind: selectedResource?.kind});
-      }
-    };
   }, [dispatch, selectedResource, selectedFilePath, setFormData]);
 
   useEffect(() => {

diff --git a/src/components/organisms/ActionsPane/ActionsPane.tsx b/src/components/organisms/ActionsPane/ActionsPane.tsx
@@ -425,7 +425,13 @@ const ActionsPane: React.FC = () => {
           onChange={k => {
             dispatch(setActiveEditorTab(k as ActionPaneTab));
             if (k === 'graph') {
-              trackEvent('edit/graphview');
+              trackEvent('edit/graphview', {resourceKind: selectedResource?.kind});
+            }
+            if (k === 'form') {
+              trackEvent('edit/form_editor', {resourceKind: selectedResource?.kind});
+            }
+            if (k === 'source') {
+              trackEvent('edit/source', {resourceKind: selectedResource?.kind});
             }
           }}
           tabBarExtraContent={

diff --git a/src/editor/enhancers/k8sResource/refs.ts b/src/editor/enhancers/k8sResource/refs.ts
@@ -17,6 +17,7 @@ import {createGlyphDecoration, createMarkdownString} from '@editor/editor.utils'
 import {RefPosition, ResourceRef, ResourceRefType, areRefPosEqual} from '@monokle/validation';
 import {AppDispatch} from '@shared/models/appDispatch';
 import {ResourceMeta, isLocalResourceMeta} from '@shared/models/k8sResource';
+import {trackEvent} from '@shared/utils';
 
 import {createEditorEnhancer} from '../createEnhancer';
 
@@ -205,6 +206,7 @@ const addEditorCommandForRef = (args: {resourceMeta: ResourceMeta; ref: Resource
             dispatch(
               selectResource({resourceIdentifier: {id: (ref.target as any).resourceId, storage: resourceMeta.storage}})
             );
+            trackEvent('edit/select_hover_link', {type: 'resource'});
           }
         },
       },
@@ -218,6 +220,7 @@ const addEditorCommandForRef = (args: {resourceMeta: ResourceMeta; ref: Resource
         handler: () => {
           if (ref.target?.type === 'file') {
             dispatch(selectFile({filePath: ref.target.filePath}));
+            trackEvent('edit/select_hover_link', {type: 'file'});
           }
         },
       },
@@ -231,6 +234,7 @@ const addEditorCommandForRef = (args: {resourceMeta: ResourceMeta; ref: Resource
         handler: () => {
           if (ref.target?.type === 'image') {
             dispatch(selectImage({imageId: `${ref.name}:${ref.target?.tag}`}));
+            trackEvent('edit/select_hover_link', {type: 'image'});
           }
         },
       },
@@ -248,9 +252,12 @@ const onClickRefLink = (args: {resourceMeta: ResourceMeta; ref: ResourceRef; dis
   if (ref.target?.type === 'resource' && ref.target.resourceId) {
     // is the storage of the target resource the same as the current resource?
     dispatch(selectResource({resourceIdentifier: {id: ref.target.resourceId, storage: resourceMeta.storage}}));
+    trackEvent('edit/select_hover_link', {type: 'resource'});
   } else if (ref.target?.type === 'file' && ref.target.filePath) {
     dispatch(selectFile({filePath: ref.target.filePath}));
+    trackEvent('edit/select_hover_link', {type: 'file'});
   } else if (ref.target?.type === 'image') {
     dispatch(selectImage({imageId: `${ref.name}:${ref.target?.tag}`}));
+    trackEvent('edit/select_hover_link', {type: 'image'});
   }
 };
diff --git a/src/shared/models/telemetry.ts b/src/shared/models/telemetry.ts
@@ -68,8 +68,10 @@ export type EventMap = {
   'graph/select_image': undefined;
   'edit/template_use': {templateID: string};
   'edit/form_editor': {resourceKind?: string};
+  'edit/source': {resourceKind?: string};
   'edit/side_by_side_editor': {resourceKind: string};
-  'edit/graphview': {kind: string};
+  'edit/select_hover_link': {type: 'resource' | 'image' | 'file'};
+  'edit/graphview': {resourceKind?: string};
   'create/file': undefined;
   'create/folder': undefined;
   'create/resource': {resourceKind: string};