fix: review comments

kubeshop · Apr 14, 2023 · 50632e9 · 50632e9
1 parent 392b8b9
commit 50632e9
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/src/components/organisms/NavigatorPane/KindRenderer/ResourceCounter.tsx b/src/components/organisms/NavigatorPane/KindRenderer/ResourceCounter.tsx
@@ -1,7 +1,7 @@
 import styled from 'styled-components';
 
 import {useAppSelector} from '@redux/hooks';
-import {navigatorResourcesSelector} from '@redux/selectors/resourceSelectors';
+import {navigatorResourcesCountSelector} from '@redux/selectors/resourceSelectors';
 
 import {Colors, FontColors} from '@shared/styles';
 
@@ -13,11 +13,11 @@ type Props = {
 
 function ResourceCounter({kind, isSelected, onClick}: Props) {
   const isCollapsed = useAppSelector(state => state.ui.navigator.collapsedResourceKinds.includes(kind));
-  const navigatorResources = useAppSelector(state => navigatorResourcesSelector(state));
+  const navigatorResourcesCount = useAppSelector(navigatorResourcesCountSelector);
 
   return (
     <Counter selected={isSelected && isCollapsed} onClick={onClick}>
-      {navigatorResources.filter(r => r.kind === kind).length}
+      {navigatorResourcesCount}
     </Counter>
   );
 }

diff --git a/src/redux/selectors/resourceSelectors.ts b/src/redux/selectors/resourceSelectors.ts
@@ -259,3 +259,8 @@ export const resourceNavigatorSelector = createSelector(
     return list;
   }
 );
+
+export const navigatorResourcesCountSelector = createSelector(
+  resourceNavigatorSelector,
+  navigatorResources => navigatorResources.length
+);