feat: add apple id

kubeshop · Sep 29, 2021 · 499df2e · 499df2e
1 parent f1205cb
commit 499df2e
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 2 deletions.
diff --git a/.github/workflows/monokle-sign-test.yml b/.github/workflows/monokle-sign-test.yml
@@ -85,6 +85,8 @@ jobs:
           NOTARIZE: true
           CSC_LINK: ${{ secrets.MONOKLE_MACOS_CERTS }}
           CSC_KEY_PASSWORD: ${{ secrets.MONOKLE_MACOS_CERTS_PASSWORD }}
+          APPLE_ID: ${{ secrets.APPLE_ID }}
+          APPLE_ID_PASSWORD: ${{ secrets.APPLE_ID_PASSWORD }}
 
       # Check Binary Size
       - name: Build Succeeded

diff --git a/notarization/afterSignHook.js b/notarization/afterSignHook.js
@@ -33,8 +33,8 @@ module.exports = async function (params) {
     await electron_notarize.notarize({
       appBundleId: appId,
       appPath: appPath,
-      appleId: process.env.appleId,
-      appleIdPassword: process.env.appleIdPassword,
+      appleId: process.env.APPLE_ID,
+      appleIdPassword: process.env.APPLE_ID_PASSWORD,
     });
   } catch (error) {
     console.error(error);

diff --git a/package.json b/package.json
@@ -144,11 +144,14 @@
       "category": "public.app-category.utilities",
       "icon": "build/icon.png",
       "hardenedRuntime": true,
+      "gatekeeperAssess": false,
       "entitlements": "./electron/src/entitlements.mac.inherit.plist",
+      "entitlementsInherit": "./electron/src/entitlements.mac.inherit.plist",
       "target": [
         "dmg"
       ]
     },
+    "artifactName": "${productName}-${version}.${ext}",
     "afterSign": "./notarization/afterSignHook.js",
     "dmg": {
       "icon": "build/icon.png",