fix: navigator sections isVisible handling

kubeshop · Nov 2, 2021 · 1f4ad43 · 1f4ad43
1 parent c26eb75
commit 1f4ad43
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 6 deletions.
diff --git a/src/navsections/K8sResourceSectionBlueprint/ResourceKindSectionBlueprint.ts b/src/navsections/K8sResourceSectionBlueprint/ResourceKindSectionBlueprint.ts
@@ -86,9 +86,6 @@ export function makeResourceKindNavSection(
       isInitialized: scope => {
         return scope.activeResources.length > 0;
       },
-      isVisible: scope => {
-        return scope.activeResources.length === 0;
-      },
       shouldBeVisibleBeforeInitialized: true,
     },
     itemBlueprint: {

diff --git a/src/navsections/sectionBlueprintMiddleware.ts b/src/navsections/sectionBlueprintMiddleware.ts
@@ -197,9 +197,8 @@ const processSectionBlueprints = (state: RootState, dispatch: AppDispatch) => {
       isVisible:
         Boolean(sectionBuilder?.shouldBeVisibleBeforeInitialized === true && !isSectionInitialized) ||
         (isSectionInitialized &&
-          (Boolean(sectionBuilder?.isVisible && sectionBuilder.isVisible(sectionScope, rawItems)) ||
-            visibleItemIds.length > 0 ||
-            visibleGroupIds.length > 0)),
+          Boolean(sectionBuilder?.isVisible ? sectionBuilder.isVisible(sectionScope, rawItems) : true) &&
+          (visibleItemIds.length > 0 || visibleGroupIds.length > 0)),
       isInitialized: isSectionInitialized,
       isSelected: isSectionSelected,
       isHighlighted: isSectionHighlighted,